fix bug in plot_boundaries of plot2D
#2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
May 21, 2022
|
Does it work correctly if the |
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
- Coverage 73.25% 73.11% -0.15%
==========================================
Files 17 17
Lines 4902 4895 -7
==========================================
- Hits 3591 3579 -12
- Misses 1311 1316 +5
|
Yes, it works correctly in this case as well. Here is a demonstration based on the example above with a PML thickness of 2.0. The nonpml_vol = mp.Volume(center=mp.Vector3(),
size=mp.Vector3(12,10,0))
sim.plot2D(fields=mp.Ez,
output_plane=nonpml_vol)
For comparison, here is the output using the master branch (5275f43). The PML thickness incorrectly appears as 2.0.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2022.
Currently, the
plot_boundariessubroutine ofplot2Dproduces the incorrect output when theoutput_planeparameter passed toplot2Ddefines an area which does not include the PML boundaries. This can be demonstrated using theexamples/oblique-planewave.py. The output region defined byoutput_planedoes not include the PMLs but they incorrectly appear in the wrong location in the output.Also includes some general formatting tweaks to
visualization.pyto improve readability.With this PR, the output does not include the PML boundaries in the x direction.
cc @hammy4815